linux-kernel - Re: [PATCH,RFC] perf: panic due to inclied cpu context task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301500659.4859.195.camel@twins>
Date:	Wed, 30 Mar 2011 17:57:39 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, Paul Mackerras <paulus@...ba.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH,RFC] perf: panic due to inclied cpu context task_ctx
 value

On Wed, 2011-03-30 at 17:52 +0200, Oleg Nesterov wrote:
> On 03/30, Peter Zijlstra wrote:
> >
> > On Wed, 2011-03-30 at 17:32 +0200, Oleg Nesterov wrote:
> > > > +#ifdef HAVE_JUMP_LABEL
> > > > +static inline
> > > > +void perf_sched_events_inc(void)
> > > > +{
> > > > +     jump_label_inc(&perf_sched_events_out);
> > > > +     smp_mb__after_atomic_inc();
> > > > +     jump_label_inc(&perf_sched_events_in);
> > > > +}
> > >
> > > probably smp_mb__after_atomic_inc() needs a comment...
> >
> > You don't need it, jump_label_inc() uses atomic_add_return() which
> > implies a full mb.
> 
> Yes, but only if HAVE_JUMP_LABEL.

argh, indeed.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/