linux-kernel - Re: Help with dma on PCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110330101555.573491e1@bike.lwn.net>
Date:	Wed, 30 Mar 2011 10:15:55 -0600
From:	Jonathan Corbet <corbet@....net>
To:	Luis Rossi <luisf.rossi@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Help with dma on PCI driver

On Wed, 30 Mar 2011 13:11:40 -0300
Luis Rossi <luisf.rossi@...il.com> wrote:

> should i stop the inti function on the device register,
> and make all the rest inside probe? It makes a lot of sense as the
> rest should be called just if the device is connected...

Yes, you should.  Also, please look at your cdev_add() call and bear in
mind that your device can be accessed immediately after that call.  You
should not call cdev_add() until the device is completely initialized and
ready to go.

Some thought given to locking would also not be misplaced.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/