linux-kernel - Re: [GIT pull] irq fixes for .39.rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikeMFpxVW2bU+CXh=VVPBf2Tm4ccMFBUELSeVy4@mail.gmail.com>
Date:	Wed, 30 Mar 2011 09:50:43 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [GIT pull] irq fixes for .39.rc

On Wed, Mar 30, 2011 at 9:46 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Wed, 30 Mar 2011, Thomas Gleixner wrote:
>> On Wed, 30 Mar 2011, Linus Torvalds wrote:
>> >
>> > which just makes me go "Somebody is really really confused".
>> >
>> > The whole thing may mean that both handler_data and chip_data contains
>> > the right thing, but it still makes me go "WTF?".
>> >
>> > Which way should I resolve it?
>>
>> get_irq_desc_data() maps to irq_desc_get_handler_data() so Richards
>> resolution is correct even if the other might work as well.
>
> Older code which was not using any accessors has:
>
>      desc->handler_data
>
> But yeah, the init stuff is confusing as hell.

So I took the handler_data version, but I do think the chip_data one
seems to make more conceptual sense. It would be good if somebody who
can actually test that code and knows all the details of the
particular irq controller could just take a look, and decide on using
one or the other, and not both.

I pushed out my resolution (but the mirroring has been slow lately, so
it might take a while to show up on git.kernel.org - it's there on
master now, though)

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/