linux-kernel - Re: [PATCH 1/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110330194412.GA26261@pengutronix.de>
Date:	Wed, 30 Mar 2011 21:44:12 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	Christopher Heiny <cheiny@...aptics.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Jean Delvare <khali@...ux-fr.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linux Input <linux-input@...r.kernel.org>,
	Allie Xiong <axiong@...aptics.com>,
	William Manson <WManson@...aptics.com>,
	Joerie de Gram <j.de.gram@...il.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Naveen Kumar Gaddipati <naveen.gaddipati@...ricsson.com>
Subject: Re: [PATCH 1/3] input/touchscreen: Synaptics RMI4 Touchscreen
 Driver

On Wed, Mar 30, 2011 at 11:36:04AM -0700, Christopher Heiny wrote:
> On 03/30/2011 01:02 AM, Wolfram Sang wrote:
> >* PGP Signed by an unknown key: 03/30/2011 at 12:02:23 AM
> >Hi,
> >
> >>+	retval = rmi_register_sensor(&instancedata->rmiphysdrvr, platformdata->perfunctiondata);
> >>+	if (retval) {
> >>+		dev_err(&client->dev, "%s: Failed to Register %s sensor drivers\n",
> >>+				__func__, instancedata->rmiphysdrvr.name);
> >>+		i2c_set_clientdata(client, NULL);
> >
> >I originally just wanted to say that this line can be removed. Then I
> >remembered that I already sent a patch for a similar driver in staging
> >(dc7b202a4ee6cb686e2bbef80c84443f43ec91bd). The staging driver looks in
> >a better shape to me. Do you know about it?
> 
> That call is required in order to register the sensor device on the

I meant the last line, setting clientdata to NULL is not needed anymore.

> I'm afraid I can't locate the commit you specified.

Direct search failed for me, too, but here is the link:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=dc7b202a4ee6cb686e2bbef80c84443f43ec91bd

> I do find a driver in staging/ste_rmi4/synaptics_i2c_rmi4.[ch] - is that the
> one?

Yes, I meant this one. Looks a bit better from a glimpse; no '#if 0'-blocks,
much less printk. I just wondered how these two are related and if it makes
sense to join efforts here.

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)