linux-kernel - Re: [PATCH 09/23] hdaps: Convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1301450430.4113.24.camel@Joe-Laptop>
Date:	Tue, 29 Mar 2011 19:00:30 -0700
From:	Joe Perches <joe@...ches.com>
To:	Lucas De Marchi <lucas.de.marchi@...il.com>
Cc:	Matthew Garrett <mjg@...hat.com>, Frank Seidel <frank@...eidel.de>,
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 09/23] hdaps: Convert printks to pr_<level>

On Tue, 2011-03-29 at 22:54 -0300, Lucas De Marchi wrote:
> > diff --git a/drivers/platform/x86/hdaps.c b/drivers/platform/x86/hdaps.c
> > @@ -238,7 +240,7 @@ static int hdaps_device_init(void)
> >                     __check_latch(0x1611, 0x01))
> >                goto out;
> >
> > -       printk(KERN_DEBUG "hdaps: initial latch check good (0x%02x).\n",
> > +       printk(KERN_DEBUG "hdaps: initial latch check good (0x%02x)\n",
> 
> Shouldn't this be pr_debug() or pr_devel() ?

Hi Lucas.

Using pr_debug changes behavior unless
CONFIG_DYNAMIC_DEBUG or #define DEBUG is used.

I prefer not to change those unless there's
agreement.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/