linux-kernel - [PATCH] [218/275] mmc: sdio: remember new card RCA when redetecting card

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110330210743.3A7633E1A05@tassilo.jf.intel.com>
Date:	Wed, 30 Mar 2011 14:07:43 -0700 (PDT)
From:	Andi Kleen <andi@...stfloor.org>
To:	stefan.xk.nilsson@...ricsson.com, ak@...ux.intel.com,
	ulf.hansson@...ricsson.com, pawel.wieczorkiewicz@...ricsson.com,
	linus.walleij@...aro.org, cjb@...top.org, gregkh@...e.de,
	linux-kernel@...r.kernel.org, stable@...nel.org,
	tim.bird@...sony.com
Subject: [PATCH] [218/275] mmc: sdio: remember new card RCA when redetecting card

2.6.35-longterm review patch.  If anyone has any objections, please let me know.

------------------
From: Stefan Nilsson XK <stefan.xk.nilsson@...ricsson.com>

commit 0aab3995485b8a994bf29a995a008c9ea4a28054 upstream.

During redetection of a SDIO card, a request for a new card RCA
was submitted to the card, but was then overwritten by the old RCA.
This caused the card to be deselected instead of selected when using
the incorrect RCA.  This bug's been present since the "oldcard"
handling was introduced in 2.6.32.

Signed-off-by: Stefan Nilsson XK <stefan.xk.nilsson@...ricsson.com>
Signed-off-by: Andi Kleen <ak@...ux.intel.com>
Reviewed-by: Ulf Hansson <ulf.hansson@...ricsson.com>
Reviewed-by: Pawel Wieczorkiewicz <pawel.wieczorkiewicz@...ricsson.com>
Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
Signed-off-by: Chris Ball <cjb@...top.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

---
 drivers/mmc/core/sdio.c |    8 ++++++++
 1 file changed, 8 insertions(+)

Index: linux-2.6.35.y/drivers/mmc/core/sdio.c
===================================================================
--- linux-2.6.35.y.orig/drivers/mmc/core/sdio.c	2011-03-29 22:50:30.116487813 -0700
+++ linux-2.6.35.y/drivers/mmc/core/sdio.c	2011-03-29 23:03:02.787228853 -0700
@@ -309,6 +309,14 @@
 		if (err)
 			goto remove;
 
+		/*
+		 * Update oldcard with the new RCA received from the SDIO
+		 * device -- we're doing this so that it's updated in the
+		 * "card" struct when oldcard overwrites that later.
+		 */
+		if (oldcard)
+			oldcard->rca = card->rca;
+
 		mmc_set_bus_mode(host, MMC_BUSMODE_PUSHPULL);
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/