linux-kernel - [PATCH] [109/275] kernel/user.c: add lock release annotation on free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110330210548.6BD753E1A05@tassilo.jf.intel.com>
Date:	Wed, 30 Mar 2011 14:05:48 -0700 (PDT)
From:	Andi Kleen <andi@...stfloor.org>
To:	namhyung@...il.com, efault@....de, linux-kernel@...r.kernel.org,
	ak@...ux.intel.com, mingo@...e.hu, dhaval.giani@...il.com,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	gregkh@...e.de, linux-kernel@...r.kernel.org, stable@...nel.org,
	tim.bird@...sony.com
Subject: [PATCH] [109/275] kernel/user.c: add lock release annotation on free_user()

2.6.35-longterm review patch.  If anyone has any objections, please let me know.

------------------

From: Namhyung Kim <namhyung@...il.com>

commit 571428be550fbe37160596995e96ad398873fcbd upstream.

free_user() releases uidhash_lock but was missing annotation.  Add it.
This removes following sparse warnings:

 include/linux/spinlock.h:339:9: warning: context imbalance in 'free_user' - unexpected unlock
 kernel/user.c:120:6: warning: context imbalance in 'free_uid' - wrong count at exit

Signed-off-by: Namhyung Kim <namhyung@...il.com>
Signed-off-by: Andi Kleen <ak@...ux.intel.com>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: Dhaval Giani <dhaval.giani@...il.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
Signed-off-by: Mike Galbraith <efault@....de>
Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>


---
 kernel/user.c |    1 +
 1 file changed, 1 insertion(+)

Index: linux-2.6.35.y/kernel/user.c
===================================================================
--- linux-2.6.35.y.orig/kernel/user.c	2011-03-29 22:51:25.263076751 -0700
+++ linux-2.6.35.y/kernel/user.c	2011-03-29 23:03:00.463288316 -0700
@@ -91,6 +91,7 @@
  * upon function exit.
  */
 static void free_user(struct user_struct *up, unsigned long flags)
+	__releases(&uidhash_lock)
 {
 	uid_hash_remove(up);
 	spin_unlock_irqrestore(&uidhash_lock, flags);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/