linux-kernel - Re: Merge window closed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110330222909.GA26174@infradead.org>
Date:	Wed, 30 Mar 2011 18:29:09 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	Christoph Hellwig <hch@...radead.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Merge window closed - 2.6.39-rc1 out

 (1) it still has the totally stupid interface of a global dispatch table.
     Either it does make sense to have different providers, in which
     case you want the dispatch table on a per-superblock or whatever
     granularity, or you really want just one and can have static calls
     into it, and get rid of this whole layer
 (2) it still requires totally pointless calls from local filesystem to
     initialize a pool ID.  The filesystem really should not need to
     care about any of this.
 (3) it's still lacking a good user submitted with it.  And with that
     I don't mean junk code shoved into staging where it's bitrotting.

It also has an entirely new bug, in that it assumes every inode has
a dentry on the alias list.  Did you only ever test this with filesystem
that do not have export operations?  Otherwise the no-dentry case should
be fairly trivial to trigger due the placement of the hooks.

And of course there's still no convincing use case for all of this.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/