linux-kernel - Re: [uClinux-dev] Re: [PATCH] NOMMU: implement access_remote_vm

Open Source and information security mailing list archives

Message-ID: <AANLkTi=1uFnONhEaLo7u-YQJJZhBFpRv36LmwKq1xYiK@mail.gmail.com>
Date:	Thu, 31 Mar 2011 14:14:07 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	uClinux development list <uclinux-dev@...inux.org>
Cc:	Greg Ungerer <gerg@...pgear.com>,
	Mike Frysinger <vapier@...too.org>,
	linux-kernel@...r.kernel.org, Greg Ungerer <gerg@...inux.org>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [uClinux-dev] Re: [PATCH] NOMMU: implement access_remote_vm

2011/3/29 Greg Ungerer <gerg@...pgear.com>:
> On 26/03/11 06:32, Mike Frysinger wrote:
>>
>> Recent vm changes brought in a new function which the core procfs code
>> utilizes.  So implement it for nommu systems too to avoid link failures.
>>
>> Signed-off-by: Mike Frysinger<vapier@...too.org>
>
> Looks good.
>
> Acked-by: Greg Ungerer <gerg@...inux.org>
>

It applys to my nuc700 arm7tdmi platform, thanks!

Tested-by: Wan ZongShun <mcuos.com@...il.com>

>
>> ---
>>  mm/nommu.c |   52 +++++++++++++++++++++++++++++++++++++++-------------
>>  1 files changed, 39 insertions(+), 13 deletions(-)
>>
>> diff --git a/mm/nommu.c b/mm/nommu.c
>> index cb86e7d..c4c542c 100644
>> --- a/mm/nommu.c
>> +++ b/mm/nommu.c
>> @@ -1971,21 +1971,10 @@ int filemap_fault(struct vm_area_struct *vma,
>> struct vm_fault *vmf)
>>  }
>>  EXPORT_SYMBOL(filemap_fault);
>>
>> -/*
>> - * Access another process' address space.
>> - * - source/target buffer must be kernel space
>> - */
>> -int access_process_vm(struct task_struct *tsk, unsigned long addr, void
>> *buf, int len, int write)
>> +static int __access_remote_vm(struct task_struct *tsk, struct mm_struct
>> *mm,
>> +               unsigned long addr, void *buf, int len, int write)
>>  {
>>        struct vm_area_struct *vma;
>> -       struct mm_struct *mm;
>> -
>> -       if (addr + len<  addr)
>> -               return 0;
>> -
>> -       mm = get_task_mm(tsk);
>> -       if (!mm)
>> -               return 0;
>>
>>        down_read(&mm->mmap_sem);
>>
>> @@ -2010,6 +1999,43 @@ int access_process_vm(struct task_struct *tsk,
>> unsigned long addr, void *buf, in
>>        }
>>
>>        up_read(&mm->mmap_sem);
>> +
>> +       return len;
>> +}
>> +
>> +/**
>> + * @access_remote_vm - access another process' address space
>> + * @mm:                the mm_struct of the target address space
>> + * @addr:      start address to access
>> + * @buf:       source or destination buffer
>> + * @len:       number of bytes to transfer
>> + * @write:     whether the access is a write
>> + *
>> + * The caller must hold a reference on @mm.
>> + */
>> +int access_remote_vm(struct mm_struct *mm, unsigned long addr,
>> +               void *buf, int len, int write)
>> +{
>> +       return __access_remote_vm(NULL, mm, addr, buf, len, write);
>> +}
>> +
>> +/*
>> + * Access another process' address space.
>> + * - source/target buffer must be kernel space
>> + */
>> +int access_process_vm(struct task_struct *tsk, unsigned long addr, void
>> *buf, int len, int write)
>> +{
>> +       struct mm_struct *mm;
>> +
>> +       if (addr + len<  addr)
>> +               return 0;
>> +
>> +       mm = get_task_mm(tsk);
>> +       if (!mm)
>> +               return 0;
>> +
>> +       len = __access_remote_vm(tsk, mm, addr, buf, len, write);
>> +
>>        mmput(mm);
>>        return len;
>>  }
>
>
> --
> ------------------------------------------------------------------------
> Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
> SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
> 8 Gardner Close                             FAX:         +61 7 3217 5323
> Milton, QLD, 4064, Australia                WEB: http://www.SnapGear.com
> _______________________________________________
> uClinux-dev mailing list
> uClinux-dev@...inux.org
> http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
> This message was resent by uclinux-dev@...inux.org
> To unsubscribe see:
> http://mailman.uclinux.org/mailman/options/uclinux-dev
>

-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@...ts.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@...glegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives