linux-kernel - Re: [PATCH] dmaengine/dw_dmac fix: dwc_scan_descriptors must compare first desc address also with llp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1301550296.18522.7.camel@vkoul-udesk3>
Date:	Thu, 31 Mar 2011 11:14:56 +0530
From:	"Koul, Vinod" <vinod.koul@...el.com>
To:	Viresh Kumar <viresh.kumar@...com>
Cc:	dan.j.williams@...el.com, linux-kernel@...r.kernel.org,
	jamie@...ieiles.com, shiraz.hashim@...com, armando.visconti@...com,
	ajay.khandelwal@...com, amit.goel@...com, viresh.linux@...il.com
Subject: Re: [PATCH] dmaengine/dw_dmac fix: dwc_scan_descriptors must
 compare first desc address also with llp

On Thu, 2011-03-24 at 11:32 +0530, Viresh Kumar wrote:
> dwc_scan_descriptors scans all descriptors from active_list in case transfer is
> not completed.  It compares first_desc->lli.llp, and then all childrens of its
> tx_list. But it doesn't compare its own address, i.e. first_desc->txd.phys, as
> this is what we have initially programmed into the controller register. So this
> causes dma to stop and finish a transfer, which was never started. And thus
> fail.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...com>
> ---
>  drivers/dma/dw_dmac.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/dma/dw_dmac.c b/drivers/dma/dw_dmac.c
> index b95e6d3..1bd4803 100644
> --- a/drivers/dma/dw_dmac.c
> +++ b/drivers/dma/dw_dmac.c
> @@ -304,6 +304,11 @@ static void dwc_scan_descriptors(struct dw_dma *dw, struct dw_dma_chan *dwc)
>  	dev_vdbg(chan2dev(&dwc->chan), "scan_descriptors: llp=0x%x\n", llp);
>  
>  	list_for_each_entry_safe(desc, _desc, &dwc->active_list, desc_node) {
> +		/* check first descriptors addr */
> +		if (desc->txd.phys == llp)
> +			return;
> +
> +		/* check first descriptors llp */
>  		if (desc->lli.llp == llp)
>  			/* This one is currently in progress */
>  			return;

Applied, Thanks

-- 
~Vinod

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/