linux-kernel - Re: [PATCH] acer-wmi: does not set persistence state by rfkill_init_sw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110331103054.73438ab5@schatten.dmk.lab>
Date:	Thu, 31 Mar 2011 10:30:54 +0200
From:	Florian Mickler <florian@...kler.org>
To:	Florian Mickler <florian@...kler.org>
Cc:	stable@...nel.org, linux-kernel@...r.kernel.org,
	"Lee, Chun-Yi" <joeyli.kernel@...il.com>,
	Carlos Corbacho <carlos@...angeworlds.co.uk>,
	Matthew Garrett <mjg@...hat.com>,
	Dmitry Torokhov <dtor@...l.ru>,
	Corentin Chary <corentincj@...aif.net>,
	Johannes Berg <johannes@...solutions.net>,
	"Lee, Chun-Yi" <jlee@...ell.com>
Subject: Re: [PATCH] acer-wmi: does not set persistence state by
 rfkill_init_sw_state

On Wed, 30 Mar 2011 22:17:57 +0200
Florian Mickler <florian@...kler.org> wrote:

> From: Lee, Chun-Yi <joeyli.kernel@...il.com>
> 
> Acer BIOS keeps devices state when system reboot, but reset to default
> device states (Wlan on, Bluetooth off, wwan on) if system cold boot.
> That means BIOS's initial state is not always real persistence.
> 
> So, removed rfkill_init_sw_state because it sets initial state to
> persistence then replicate to other new killswitch when rfkill-input
> enabled.
> After removed it, acer-wmi set initial soft-block state after rfkill
> register, and doesn't allow set_block until rfkill initial finished.
> 
> Reference: bko#31002
> 	https://bugzilla.kernel.org/show_bug.cgi?id=31002
> 
> Cc: Carlos Corbacho <carlos@...angeworlds.co.uk>
> Cc: Matthew Garrett <mjg@...hat.com>
> Cc: Dmitry Torokhov <dtor@...l.ru>
> Cc: Corentin Chary <corentincj@...aif.net>
> Cc: Johannes Berg <johannes@...solutions.net>
> Signed-off-by: Lee, Chun-Yi <jlee@...ell.com>
> Signed-off-by: Matthew Garrett <mjg@...hat.com>
> Tested-by: OldÅich JedliÄka <oldium.pro@...nam.cz>
> Signed-off-by: Florian Mickler <florian@...kler.org>
> ---
> 
> This fixes a regression, but no stable annotation was given...
> 
> Oversight? Matthew/Chun-Yi please take a look. 
> 

I forgot: This is upstream
commit 8215af019040ce9182728afee9642d8fdeb17f59 .

As for the Tested-by:, I think that's borked in git. At least I can't
get it out of git correctly. It should be:
Tested-by: Oldřich Jedlička <oldium.pro@...nam.cz> 

Thanks,
Flo

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/