linux-kernel - Re: [PATCH v2] x86: UV kdump reboot fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110331091456.GB8296@elte.hu>
Date:	Thu, 31 Mar 2011 11:14:56 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cliff Wickman <cpw@....com>
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, tglx@...utronix.de,
	rja@....com
Subject: Re: [PATCH v2] x86: UV kdump reboot fix


* Cliff Wickman <cpw@....com> wrote:

> From: Cliff Wickman <cpw@....com>
> 
> After a crash dump on an SGI Altix UV system the crash kernel fails to
> cause a reboot.  EFI mode is disabled in the kdump kernel, so only the
> reboot_type of BOOT_ACPI works.
> 
> native_machine_restart() is the generic restart function.  This patch
> overrides the generic version with a UV-specific version.
> (an earlier (6Dec2010) version of this patch was nack'd as it patched
>  native_machine_restart() with special case is_uv_system() kludge)

It was NAKed because a special case is_uv_system() kludge was put into
*generic x86 code*.

Kludging the generic code some more:

 >  arch/x86/include/asm/uv/uv.h       |    1 +
 >  arch/x86/kernel/apic/x2apic_uv_x.c |   18 ++++++++++++++++++
 >  arch/x86/kernel/reboot.c           |    2 +-
 >  3 files changed, 20 insertions(+), 1 deletion(-)

Does not help either.

The clean solution would be to add the reboot_type setting to an UV specific 
initialization function. That way only UV is affected and there's no extra 
kludge either, as reboot_type is already global.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/