linux-kernel - Re: [PATCH][POKE] Skip looking for ioapic overrides when ioapics are not present

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110331125941.661a0af9@schatten.dmk.lab>
Date:	Thu, 31 Mar 2011 12:59:41 +0200
From:	Florian Mickler <florian@...kler.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	kurup_avinash@...oo.com, maciej.rutecki@...il.com, rjw@...k.pl,
	sedat.dilek@...il.com, zersaa@...il.com, stable@...nel.org
Subject: Re: [PATCH][POKE] Skip looking for ioapic overrides when ioapics
 are not present

On Thu, 31 Mar 2011 10:43:42 +0200
Ingo Molnar <mingo@...e.hu> wrote:

> 
> * Florian Mickler <florian@...kler.org> wrote:
> 
> > From: Eric W. Biederman <ebiederm@...ssion.com>
> > 
> > [I submit this as the corresponding bug report is still not closed, the patch 
> > not merged, distributions applying this patch, it is tested to work and I found
> > nowhere any resoning as to why this should be out of tree. I just guessed on
> > the stable tag and number. -Florian] 
> 
> The patch does not build when CONFIG_ACPI is disabled:
> 
>  arch/x86/kernel/apic/io_apic.c: In function ‘acpi_get_override_irq’:
>  arch/x86/kernel/apic/io_apic.c:3792:6: error: ‘acpi_irq_model’ undeclared (first use in this function)
>  arch/x86/kernel/apic/io_apic.c:3792:24: error: ‘ACPI_IRQ_MODEL_IOAPIC’ undeclared (first use in this function)
> 
> When you or Eric resubmits the fixed patch please use the improved changelog 
> below.
> 
> Thanks,
> 
> 	Ingo

Thank you. Will do if it turns out this is still necessary. 
Paul Bolle mentioned in another messgage that there is a commit in
2.6.38 to the same effect:

commit 678301ecadec24ff77ab310eebf8a32ccddb1850 
("x86, ioapic: Don't warn about non-existing IOAPICs if we have none")

Regards,
Flo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/