linux-kernel - Re: [PATCH V2] Add the support of the touchscreen keypad of tsc2007 .

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110331013600.GA3163@gmail.com>
Date:	Thu, 31 Mar 2011 09:36:02 +0800
From:	Harry Wei <jiaweiwei.xiyou@...il.com>
To:	wanlong.gao@...il.com
Cc:	khali@...ux-fr.org, broonie@...nsource.wolfsonmicro.com,
	rpurdie@...ux.intel.com, w.sang@...gutronix.de,
	dmitry.torokhov@...il.com, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org
Subject: Re: [PATCH V2] Add the support of the touchscreen keypad of
 tsc2007 .

On Sun, Mar 27, 2011 at 05:46:32PM +0800, wanlong.gao@...il.com wrote:
> From: Wanlong Gao <wanlong.gao@...il.com>
> 
> Many touchscreens support touch-keypad .
> Open the definition of the TOUCHSCREEN_TSC2007_WITH_KEYPAD, you can
> open the support of the touchscreen's keypad .
> We can add the support of the touchscreen keypad in the driver.
> In this patch , add the ts_key_pos array to determine the position
> of the key's X. And the ts_key_sensitivity can use to detemine the
> key's sensitivity. You can modify the ts_key_pos array for you own
> touchscreen keys . And modify the ts_key_sensitivity for you own
> key's sensitivity .
> If you want to modify the ts_key_map, change the position of the
> keys ,too.
> 
> Signed-off-by: Wanlong Gao <wanlong.gao@...il.com>
Reviewed-by: Harry Wei <harryxiyou@...il.com>
> ---
>  drivers/input/touchscreen/tsc2007.c |   48 +++++++++++++++++++++++++++++++++++
>  1 files changed, 48 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/tsc2007.c b/drivers/input/touchscreen/tsc2007.c
> index 80467f2..8f70fca 100644
> --- a/drivers/input/touchscreen/tsc2007.c
> +++ b/drivers/input/touchscreen/tsc2007.c
> @@ -83,6 +83,51 @@ struct tsc2007 {
>  	void			(*clear_penirq)(void);
>  };
>  
> +/*
> +#define	TOUCHSCREEN_TSC2007_WITH_KEYPAD
> +*/
> +#ifndef	TOUCHSCREEN_TSC2007_WITH_KEYPAD
> +static void ts_key_set_capacity(struct input_dev *input) {};
> +static void ts_key_up(struct input_dev *input) {};
> +static void ts_key_event(struct input_dev *input, u16 x, u16 y) {};
> +#else
> +static int ts_key_pos[] = {700, 1650, 2550, 3500};
> +static int ts_key_map[] = {KEY_MENU, KEY_HOME, KEY_BACK, KEY_SEARCH};
> +/* you can modify this value to change the touch_key's sensitivity */
> +static int ts_key_sensitivity = 50;
> +
> +static void ts_key_set_capacity(struct input_dev *input)
> +{
> +	int i;
> +	for (i = 0; i < ARRAY_SIZE(ts_key_map); i++) {
> +		input_set_capability(input, EV_KEY, ts_key_map[i]);
> +	}
You only have one statement after 'for-recycle', so it should program
like following.
for (i = 0; i < ARRAY_SIZE(ts_key_map); i++)
	input_set_capability(input, EV_KEY, ts_key_map[i]);
> +}
> +
> +/* you must have an input_sync() followed this func . */
> +static void ts_key_up(struct input_dev *input)
> +{
> +	int i;
> +	for (i = 0; i < ARRAY_SIZE(ts_key_map); i++) {
> +		input_report_key(input, ts_key_map[i], 0);
> +	}
for (i = 0; i < ARRAY_SIZE(ts_key_map); i++)
	input_report_key(input, ts_key_map[i], 0);
> +}
> +
> +static void ts_key_event(struct input_dev *input, u16 x, u16 y)
> +{
> +	int i;
> +	if (y > MAX_12BIT) {
> +		for (i = 0; i < ARRAY_SIZE(ts_key_pos); i++) {
> +			if ((x > (ts_key_pos[i] - ts_key_sensitivity)) &&
> +				(x < (ts_key_pos[i] + ts_key_sensitivity))) {
> +				input_report_key(input, ts_key_map[i], 1);
> +				input_sync(input);
> +			}
> +		}
> +	}
> +}
> +#endif
> +
>  static inline int tsc2007_xfer(struct tsc2007 *tsc, u8 cmd)
>  {
>  	s32 data;
> @@ -149,6 +194,7 @@ static void tsc2007_send_up_event(struct tsc2007 *tsc)
>  
>  	input_report_key(input, BTN_TOUCH, 0);
>  	input_report_abs(input, ABS_PRESSURE, 0);
> +	ts_key_up(input);
>  	input_sync(input);
>  }
>  
> @@ -201,6 +247,7 @@ static void tsc2007_work(struct work_struct *work)
>  		if (!ts->pendown) {
>  			dev_dbg(&ts->client->dev, "DOWN\n");
>  
> +			ts_key_event(input, tc.x, tc.y);
>  			input_report_key(input, BTN_TOUCH, 1);
>  			ts->pendown = true;
>  		}
> @@ -308,6 +355,7 @@ static int __devinit tsc2007_probe(struct i2c_client *client,
>  	input_set_abs_params(input_dev, ABS_X, 0, MAX_12BIT, 0, 0);
>  	input_set_abs_params(input_dev, ABS_Y, 0, MAX_12BIT, 0, 0);
>  	input_set_abs_params(input_dev, ABS_PRESSURE, 0, MAX_12BIT, 0, 0);
> +	ts_key_set_capacity(input_dev);
>  
>  	if (pdata->init_platform_hw)
>  		pdata->init_platform_hw();
> -- 
> 1.7.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/