linux-kernel - Re: [PATCH v3] x86: UV kdump reboot fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110331155754.GC9827@elte.hu>
Date:	Thu, 31 Mar 2011 17:57:54 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Cliff Wickman <cpw@....com>
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, tglx@...utronix.de,
	rja@....com
Subject: Re: [PATCH v3] x86: UV kdump reboot fix


* Cliff Wickman <cpw@....com> wrote:

> Diffed against 2.6.38-rc8 (current tip tree)

It does not apply here:

patching file arch/x86/kernel/apic/x2apic_uv_x.c
Hunk #1 FAILED at 23.
Hunk #2 succeeded at 35 (offset 1 line).
Hunk #3 succeeded at 812 (offset 1 line).
1 out of 3 hunks FAILED -- rejects in file arch/x86/kernel/apic/x2apic_uv_x.c

But yeah, the patch looks good now.

One minor nit, please watch out for the proper capitalization of sentences:

> +
> +	/*
> +	 * for a kdump kernel the reset must be BOOT_ACPI, not BOOT_EFI, as
> +	 * EFI is not enabled in the kdump kernel.
> +	 */
> +	if (is_kdump_kernel())
> +		reboot_type = BOOT_ACPI;

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/