linux-kernel - Re: [PATCH 0/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4D93E85D.6080204@synaptics.com>
Date:	Wed, 30 Mar 2011 19:35:09 -0700
From:	Christopher Heiny <cheiny@...aptics.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
CC:	Jean Delvare <khali@...ux-fr.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Linux Input <linux-input@...r.kernel.org>,
	Allie Xiong <axiong@...aptics.com>,
	William Manson <WManson@...aptics.com>,
	Joerie de Gram <j.de.gram@...il.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Naveen Kumar Gaddipati <naveen.gaddipati@...ricsson.com>
Subject: Re: [PATCH 0/3] input/touchscreen: Synaptics RMI4 Touchscreen Driver

On 03/30/2011 01:02 PM, Dmitry Torokhov wrote:
> Hi Chris,
>
> On Wed, Mar 30, 2011 at 07:05:24AM -0700, Christopher Heiny wrote:
>> This patch implements a driver supporting Synaptics ClearPad and other
>> touchscreens that use the RMI4 protocol, as defined here:
>>
>>      http://www.synaptics.com/sites/default/files/511-000136-01_revD.pdf
>>
>> This patch is against the v2.6.38 tag of Linus' kernel tree, commit
>> 521cb40b0c44418a4fd36dc633f575813d59a43d.  Note that previous patches
>> were against the synaptics-rmi4 branch of Dmitry Torokhov's input
>> tree.  At Dmitry's request, we have switched the base for our work
>> to v2.6.38 - this should make it easier for people to pick up and
>> test this and future patches.
>>
>
> The source as sumitted is quite "dirty" i.e. littered with multiple #if
> 0...#endif etc. Cooudl you please clean it up and resubmit so that
> unneeded details/code would not get into the way of reviiewing the
> driver?

I've done some tidy up.  Two #if 0's still exist, surrounding code that 
causes problems on some dev systems.  The remaining #if 0's have been 
removed or converted to a more conventional and compact approach that 
shouldn't interfere with understanding the code.

I've also removed a bunch of extraneous printks.

Patch to follow in a few minutes.

						Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/