linux-kernel - Re: [PATCH] add support for Lenovo tablet ID (0xE6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinB6GnF4gsX=-hXSLy9M1pUG1Y4W-sD_=4jdODi@mail.gmail.com>
Date:	Thu, 31 Mar 2011 13:21:09 -0500
From:	Chris Bagwell <chris@...bagwell.com>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Manoj Iyer <manoj.iyer@...onical.com>,
	linux-kernel@...r.kernel.org, pingc@...om.com
Subject: Re: [PATCH] add support for Lenovo tablet ID (0xE6)

On Thu, Mar 31, 2011 at 1:07 PM, Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
> On Thu, Mar 31, 2011 at 12:58:57PM -0500, Chris Bagwell wrote:
>> On Thu, Mar 31, 2011 at 12:43 PM, Dmitry Torokhov
>> <dmitry.torokhov@...il.com> wrote:
>> > On Thu, Mar 31, 2011 at 12:20:52PM -0500, Manoj Iyer wrote:
>> >> Signed-off-by: Manoj Iyer <manoj.iyer@...onical.com>
>> >> ---
>> >>  drivers/input/tablet/wacom_wac.c |    3 +++
>> >>  1 files changed, 3 insertions(+), 0 deletions(-)
>> >>
>> >> diff --git a/drivers/input/tablet/wacom_wac.c b/drivers/input/tablet/wacom_wac.c
>> >> index 5597637..f751224 100644
>> >> --- a/drivers/input/tablet/wacom_wac.c
>> >> +++ b/drivers/input/tablet/wacom_wac.c
>> >> @@ -1364,6 +1364,8 @@ static const struct wacom_features wacom_features_0xE2 =
>> >>       { "Wacom ISDv4 E2",       WACOM_PKGLEN_TPC2FG,    26202, 16325,  255,  0, TABLETPC2FG };
>> >>  static const struct wacom_features wacom_features_0xE3 =
>> >>       { "Wacom ISDv4 E3",       WACOM_PKGLEN_TPC2FG,    26202, 16325,  255,  0, TABLETPC2FG };
>> >> +static const struct wacom_features wacom_features_0xE6 =
>> >> +     { "ISD-V4",               WACOM_PKGLEN_TPC2FG,    27760, 15694,  255,  0, TABLETPC2FG };
>> >
>> > Manoj, shouldn't we call it "Wacom ISDv4 E6" to be consistent?
>>
>> I think its best to rename to be consistent with others in series.
>>
>> >
>> > Ping, is resolution the same as with other "ISDv4"s?
>>
>> My guess is yes.
>>
>> Note: There is a patch from Ping that you recently accepted but I do
>> not see on a branch yet (maybe I'm looking in wrong place).
>
> If we are talking about the same thing it shoudl be in my 'for-linus'
> branch.
>

Ah, yes.  There it is.

The for-linus and next branches are quite different in this area of
file.  The patch of this email would not apply cleanly to for-linus.

My suggestion is to use value of 0xE3 for which ever branch this is
merged to... but best for Ping to ack.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/