linux-kernel - Re: Linux 2.6.33.8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D94C666.3060206@osadl.org>
Date:	Thu, 31 Mar 2011 20:22:30 +0200
From:	Carsten Emde <C.Emde@...dl.org>
To:	Greg KH <gregkh@...e.de>
CC:	linux-kernel@...r.kernel.org,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>,
	"H. Peter Anvin" <hpa@...ux.intel.com>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Len Brown <lenb@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.hl>,
	Asit Mallick <asit.k.mallick@...el.com>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: Linux 2.6.33.8

Greg,

> I'm announcing the release of the 2.6.33.8 kernel.
>
> This is primarily for the use of those people who are stuck using the
> .33-rt kernel.  Anyone else who really wants to use the .33 kernel tree
> is welcome to use this one as well.
Thanks a lot for your work. It's highly appreciated.

While preparing 2.6.33.8/9 plus PREEMPT_RT patches for quality
assurance in our farm, I found that the "halt" command no longer
powers down the pretest machine (i7/Gulftown); this misbehavior occurs
with and without the PREEMPT_RT patches.

2.6.33.7:
# halt
sd 0:0:0:0: [sda] Synchronizing SCSI cache
sd 0:0:0:0: [sda] Stopping disk
sd 2:0:0:0: [sdb] Synchronizing SCSI cache
sd 2:0:0:0: [sdb] Stopping disk
The machine is powered down.

2.6.33.8:
sd 0:0:0:0: [sda] Synchronizing SCSI cache
sd 0:0:0:0: [sda] Stopping disk
sd 2:0:0:0: [sdb] Synchronizing SCSI cache
sd 2:0:0:0: [sdb] Stopping disk
ACPI: Preparing to enter system sleep state S5
Disabling non-boot CPUs ...
The machine is NOT powered down. Can be powered down only by pulling
the power plug or holding the on/off button for 5 seconds.

Bisecting from 2.6.33.7 to 2.6.33.8 revealed:
74a6e0fd8fc216cfa5edcde4bd356a8972cbc74c is the first bad commit
commit 74a6e0fd8fc216cfa5edcde4bd356a8972cbc74c
Author: H. Peter Anvin <hpa@...ux.intel.com>
Date:   Fri Dec 10 23:57:04 2010 -0500

     x86, hotplug: Use mwait to offline a processor, fix the legacy case

     upstream ea53069231f9317062910d6e772cca4ce93de8c8
     x86, hotplug: Use mwait to offline a processor, fix the legacy case

     Here included also some small follow-on patches to the same code:

     upstream a68e5c94f7d3dd64fef34dd5d97e365cae4bb42a
     x86, hotplug: Move WBINVD back outside the play_dead loop

     upstream ce5f68246bf2385d6174856708d0b746dc378f20
     x86, hotplug: In the MWAIT case of play_dead, CLFLUSH the cache line

     https://bugzilla.kernel.org/show_bug.cgi?id=5471

     Signed-off-by: H. Peter Anvin <hpa@...ux.intel.com>
     Signed-off-by: Len Brown <len.brown@...el.com>
     Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>

With this patch
-	wbinvd_halt();
+	mwait_play_dead();	/* Only returns on failure */
applied, mwait_play_dead() is taken instead of wbinvd_halt(), and the
loop
while (1) {
         mb();
         wbinvd();
         __monitor(&current_thread_info()->flags, 0, 0);
         mb();
         __mwait(eax, 0);
}
never is left. Should native_play_dead() not have been called when
"halt" is executed?

After removing this patch, "halt" works as expected in the two kernel
versions with and without PREEMPT_RT - even after upgrading to 2.6.33.9.

Instead of the entire commit 74a6e0fd8fc216cfa5edcde4bd356a8972cbc74c,
it was also sufficient to apply the first contained upstream commit
ea53069231f9317062910d6e772cca4ce93de8c8 to reproduce the situation.

Thanks,
	Carsten.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/