linux-kernel - Re: [PATCH] drivers/net: Remove IRQF_SAMPLE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110330.222832.193698433.davem@davemloft.net>
Date:	Wed, 30 Mar 2011 22:28:32 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	martinez.javier@...il.com
Cc:	bhutchings@...arflare.com, ffainelli@...ebox.fr,
	eric.dumazet@...il.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/net: Remove IRQF_SAMPLE_RANDOM flag from
 network drivers

From: Javier Martinez Canillas <martinez.javier@...il.com>
Date: Tue, 29 Mar 2011 04:27:31 +0200

> The IRQF_SAMPLE_RANDOM flag is marked as deprecated and will be removed.
> 
> Every input point to the kernel's entropy pool have to better document the
> type of entropy source it is.
> 
> drivers/char/random.c now implements a set of interfaces that can be used for
> devices to collect enviromental noise. IRQF_SAMPLE_RANDOM will be replaced
> with these add_*_randomness exported functions.
> 
> Network drivers are not a good source of entropy. They use as a source of
> entropy essentially a remote host. Which means that the source of entropy can
> be potentially controlled by an attacker. Also, with heavy workloads the
> entropy decreases due to less hardware interrupts happening thanks to irq
> mitigation and NAPI.
> 
> If a system relies in its network interface as a entropy source it has a false
> sense of security. Systems that don't have devices whose drivers are good
> sources of entropy, should either use a hardware random number generator or
> feed the kernel's entropy pool from userspace using other sources of entropy
> such as EGD, video_entropyd, timer_entropyd and audio-entropyd.
> 
> Signed-off-by: Javier Martinez Canillas <martinez.javier@...il.com>

Appied to net-next-2.6, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/