linux-kernel - Re: [GIT PULL] omap changes for v2.6.39 merge window

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201104011441.38902.arnd@arndb.de>
Date:	Fri, 1 Apr 2011 14:41:38 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Bill Gatliff <bgat@...lgatliff.com>
Cc:	"Russell King - ARM Linux" <linux@....linux.org.uk>,
	Catalin Marinas <catalin.marinas@....com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Nicolas Pitre <nico@...xnic.net>,
	Dave Airlie <airlied@...il.com>, david@...g.hm,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Tony Lindgren <tony@...mide.com>,
	David Brown <davidb@...eaurora.org>,
	lkml <linux-kernel@...r.kernel.org>,
	linux-arm-kernel@...ts.infradead.org, linux-omap@...r.kernel.org
Subject: Re: [GIT PULL] omap changes for v2.6.39 merge window

On Thursday 31 March 2011, Bill Gatliff wrote:
> On Thu, Mar 31, 2011 at 8:01 AM, Russell King - ARM Linux <linux@....linux.org.uk> wrote:

> > Just look at the removal of AAEC2000, LH7A40x and 2000 lines from the
> > mach-types file removed 6000 lines, which in itself is about the number
> > of lines of change submitted during the last merge window for any one
> > non-ARM architecture.  At this point in time with this complaint, I've
> > absolutely no idea why I bothered to do that.  I should've left it well
> > alone and then the diffstat percentage would've been smaller.  After
> > all, it's "pointless churn".
> 
> I think you did it because it was the Right Thing To Do.  Even
> positive change can be painful at times.
> 
> The majority is exceedingly grateful for the effort you make.

Defintely. I haven't seen anyone in this thread blame Russell for the
mess. As far as I'm concerned, the code in arch/arm consists of
the well-maintained {mm,kernel,lib,common,tools,include} directories
that are actively being taken care of by Russell, and a huge amount
of crap that has accumulated in mach-* and plat-*. Some of it is
arguably better than other parts, but the problem is not that someone
in particular did a bad job writing the code. The problem is that
nobody today is pushing back hard enough on crap getting added.

There is a lot of good work going on to reduce the amount of crap in
the mach code, but my feeling is that it's not keeping up with the
rate of crap getting added by other people. In some ways, the Linaro
project has actually made this worse by helping people get their code
into shape for inclusion (which of course is generally a good thing
to do).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/