linux-kernel - Re: [PATCH] arm: tegra: fix error check in tegra2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BANLkTimxRd6X2JhchrVw45MpbdpQw8Zpeg@mail.gmail.com>
Date:	Fri, 1 Apr 2011 13:39:27 -0700
From:	Colin Cross <ccross@...roid.com>
To:	Nicolas Kaiser <nikai@...ai.net>
Cc:	Erik Gilling <konkers@...roid.com>,
	Olof Johansson <olof@...om.net>, linux-tegra@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm: tegra: fix error check in tegra2_clocks.c

On Wed, Mar 30, 2011 at 6:59 AM, Nicolas Kaiser <nikai@...ai.net> wrote:
> Checking 'rate < 0' doesn't work because 'rate' is unsigned.
>
> Signed-off-by: Nicolas Kaiser <nikai@...ai.net>
> ---
> Untested.
>
>  arch/arm/mach-tegra/tegra2_clocks.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-tegra/tegra2_clocks.c b/arch/arm/mach-tegra/tegra2_clocks.c
> index 6d7c4ee..4459470 100644
> --- a/arch/arm/mach-tegra/tegra2_clocks.c
> +++ b/arch/arm/mach-tegra/tegra2_clocks.c
> @@ -1362,14 +1362,15 @@ static int tegra_clk_shared_bus_set_rate(struct clk *c, unsigned long rate)
>  {
>        unsigned long flags;
>        int ret;
> +       long new_rate = rate;
>
> -       rate = clk_round_rate(c->parent, rate);
> -       if (rate < 0)
> -               return rate;
> +       new_rate = clk_round_rate(c->parent, new_rate);
> +       if (new_rate < 0)
> +               return new_rate;
>
>        spin_lock_irqsave(&c->parent->spinlock, flags);
>
> -       c->u.shared_bus_user.rate = rate;
> +       c->u.shared_bus_user.rate = new_rate;
>        ret = tegra_clk_shared_bus_update(c->parent);
>
>        spin_unlock_irqrestore(&c->parent->spinlock, flags);
> --
> 1.7.3.4
>

Acked-by: Colin Cross <ccross@...roid.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/