linux-kernel - Re: 2.6.38.2 breaks suspend to disk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4D9643F1.1090807@zytor.com>
Date:	Fri, 01 Apr 2011 14:30:25 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Yinghai Lu <yinghai@...nel.org>
CC:	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Ingo Molnar <mingo@...hat.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Michael Leun <lkml20101129@...ton.leun.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Mike Pagano <mpagano@...too.org>
Subject: Re: 2.6.38.2 breaks suspend to disk

On 04/01/2011 02:24 PM, Yinghai Lu wrote:
> On Fri, Apr 1, 2011 at 1:21 PM, H. Peter Anvin <hpa@...or.com> wrote:
>> On 04/01/2011 12:54 PM, Yinghai Lu wrote:
>>>
>>> ok, please check if you are happy with this one.
>>>
>>
>> The best would simply be:
>>
>>        mmu_cr4_features = read_cr4_safe();
>>
>> If this has to run before we can handle exceptions, one can verify the
>> existence by testing for the CPUID instruction (a CPU has CR4 if and
>> only if it has CPUID):
>>
>>        if (boot_cpu_data.cpuid_level >= 0)
>>                mmu_cr4_features = read_cr4_safe();
>>
>> ... since we set cpuid_level to -1 if there is no CPUID instruction.
> 
> in that case could use read_cr4 directly.
> 
> please check attached -v4
> 

Err, yes, that's what I meant.

Now, why the heck did you introduce a bunch of CONFIG_HIBERNATION #ifdefs?

	-hpa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/