linux-kernel - Re: [PATCH resend] hid-magicmouse: Increase evdev buffer size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim-tN=siA8tJVCzNZHs+oM0hN-N8Ckc+9ynnNpb@mail.gmail.com>
Date:	Fri, 1 Apr 2011 16:51:07 -0700
From:	Jeffrey Brown <jeffbrown@...roid.com>
To:	Chase Douglas <chase.douglas@...onical.com>
Cc:	Jiri Kosina <jkosina@...e.cz>,
	Henrik Rydberg <rydberg@...omail.se>,
	Simon Budig <simon@...ig.de>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH resend] hid-magicmouse: Increase evdev buffer size

I've got another change in the works that fixes this problem more
systematically.

On Fri, Apr 1, 2011 at 2:03 PM, Chase Douglas
<chase.douglas@...onical.com> wrote:
> The evdev buffer isn't big enough when you get many fingers on the
> device. Bump up the buffer to a reasonable size, matching what other
> multitouch devices use. Without this change, events may be discarded in
> the evdev buffer before they are read.
>
> Reported-by: Simon Budig <simon@...ig.de>
> Cc: Henrik Rydberg <rydberg@...omail.se>
> Cc: Jiri Kosina <jkosina@...e.cz>
> Cc: stable@...nel.org
> Signed-off-by: Chase Douglas <chase.douglas@...onical.com>
> ---
> Forgot to Cc the mailing lists on the first send.
>
>  drivers/hid/hid-magicmouse.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-magicmouse.c b/drivers/hid/hid-magicmouse.c
> index 698e645..404dcbc 100644
> --- a/drivers/hid/hid-magicmouse.c
> +++ b/drivers/hid/hid-magicmouse.c
> @@ -418,6 +418,8 @@ static void magicmouse_setup_input(struct input_dev *input, struct hid_device *h
>                        input_set_abs_params(input, ABS_MT_POSITION_Y, -2456,
>                                2565, 4, 0);
>                }
> +
> +               input_set_events_per_packet(input, 60);
>        }
>
>        if (report_undeciphered) {
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/