linux-kernel - Re: Regression 2.6.39-rc1 for sony-laptop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTikVGWM3T1y2XvwkHB+Yub5EhG1RPA@mail.gmail.com>
Date:	Sat, 2 Apr 2011 14:55:38 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Mattia Dongili <malattia@...ux.it>
Cc:	Andrea Gelmini <andrea.gelmini@...il.com>,
	Matthew Garrett <mjg59@...f.ucam.org>, anssi.hannula@....fi,
	linux-acpi@...r.kernel.org, axel.lin@...il.com, trenn@...e.de,
	len.brown@...el.com, linux-kernel@...r.kernel.org
Subject: Re: Regression 2.6.39-rc1 for sony-laptop

On 4/2/11, Mattia Dongili <malattia@...ux.it> wrote:
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -810,6 +810,11 @@ static int sony_nc_handles_cleanup(struct
> platform_device *pd)
>  static int sony_find_snc_handle(int handle)
>  {
>  	int i;
> +
> +	/* not initialized yet, return early */
> +	if (!handles)
> +		return -1;

-1 is -EPERM.  That's not the right error code here.  Maybe -EINVAL?

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/