linux-kernel - Re: [PATCH] bonding-tlb: better balance when choosing slaves

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20427.1301768703@death>
Date:	Sat, 02 Apr 2011 11:25:03 -0700
From:	Jay Vosburgh <fubar@...ibm.com>
To:	Weiping Pan(潘卫平) 
	<panweiping3@...il.com>
cc:	Andy Gospodarek (supporter:BONDING DRIVER) <andy@...yhouse.net>,
	netdev@...r.kernel.org (open list:BONDING DRIVER),
	linux-kernel@...r.kernel.org (open list)
Subject: Re: [PATCH] bonding-tlb: better balance when choosing slaves


>tlb_get_least_loaded_slave() always chooses slave from
>bonding->first_slave, that gives the beginnig slaves more chances to be used.
>
>Let tlb_get_least_loaded_slave() chooses slave from a random positon in the
>slave list, make all slaves transmit packets more balanced.

	If outgoing traffic is not being starved (i.e., connections are
being balanced such that they are stacking up on one slave but
under-utilizing another), then I don't understand what benefit this has.

	There is already some degree of randomness, as peers will be
assigned in the order that packets are transmitted to them after each
rebalance.  The busiest peers will tend to be on the earlier slaves, and
vice versa, but I'm not sure this is a bad thing.

	Does this have any real gain other than making the rx/tx
statistics for the slaves more equal over time?

	I haven't measured it, but I would expect that for small numbers
of peers, having them tend to stay on the same slaves over time is
probably a good thing.

	-J

>Signed-off-by: Weiping Pan(潘卫平) <panweiping3@...il.com>
>---
> drivers/net/bonding/bond_alb.c |   17 +++++++++++++++--
> 1 files changed, 15 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
>index 9bc5de3..9fa64b0 100644
>--- a/drivers/net/bonding/bond_alb.c
>+++ b/drivers/net/bonding/bond_alb.c
>@@ -36,6 +36,7 @@
> #include <linux/if_bonding.h>
> #include <linux/if_vlan.h>
> #include <linux/in.h>
>+#include <linux/random.h>
> #include <net/ipx.h>
> #include <net/arp.h>
> #include <net/ipv6.h>
>@@ -206,15 +207,27 @@ static long long compute_gap(struct slave *slave)
> /* Caller must hold bond lock for read */
> static struct slave *tlb_get_least_loaded_slave(struct bonding *bond)
> {
>-	struct slave *slave, *least_loaded;
>+	struct slave *slave, *least_loaded, *start_slave;
> 	long long max_gap;
> 	int i;
>+	u8 n;
>
> 	least_loaded = NULL;
>+	start_slave = bond->first_slave;
> 	max_gap = LLONG_MIN;
>+        
>+	get_random_bytes(&n, 1);
>+
>+	if (bond->slave_cnt == 0)
>+		return NULL;
>+	n = n % bond->slave_cnt;
>+
>+	for (i=0; i<n; ++i) {
>+		start_slave = start_slave->next;
>+	}
>
> 	/* Find the slave with the largest gap */
>-	bond_for_each_slave(bond, slave, i) {
>+	bond_for_each_slave_from(bond, slave, i, start_slave) {
> 		if (SLAVE_IS_OK(slave)) {
> 			long long gap = compute_gap(slave);
>
>-- 
>1.7.4
>

---
	-Jay Vosburgh, IBM Linux Technology Center, fubar@...ibm.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/