[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110402204630.GA5738@Xye>
Date: Sun, 3 Apr 2011 02:16:31 +0530
From: Raghavendra D Prabhu <rprabhu@...hang.net>
To: Michael Witten <mfwitten@...il.com>
Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Use the environment variable PYTHON if defined
* On Thu, Mar 31, 2011 at 03:29:12PM -0500, Michael Witten <mfwitten@...il.com> wrote:
>On Thu, Mar 31, 2011 at 14:15, Raghavendra D Prabhu <rprabhu@...hang.net> wrote:
>> Hi,
>> Regarding the point where it warns about python-devel not existing,
>> it looks like that existing feature test will pass even when python3 is
>> chosen and fail at a later stage. So I made this little change to feature
>> test so that it fails when python3 is chosen and perf build succeeds with
>> the war ning printed rather than failing later.
>
>Good point.
>
>However, try-cc does not run the resulting program after
>compiling it, so the test still succeeds.
>
>What you want to do is make the compilation fail;
>to do so, move your test here:
>
> #include <Python.h>
>
> #if PY_VERSION_HEX >= 0x03000000
> #error "Python 3 is not yet supported; set PYTHON{,_CONFIG}"
>
> int main(void)
> ...
>
>P.S.
>Put your replies below the email quote.
Thanks. I have attached the corrected patch and also have tested it.
--------------------------
Raghavendra Prabhu
GPG ID:D72BE977
View attachment "0001-Added-a-py3k-test-to-feature-tests.patch" of type "text/plain" (899 bytes)
Content of type "application/pgp-signature" skipped
Powered by blists - more mailing lists