linux-kernel - Re: [PATCH] arm: nomadik: avoid assigning u32 to bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110402211954.GA22545@mail.gnudd.com>
Date:	Sat, 2 Apr 2011 23:19:54 +0200
From:	Alessandro Rubini <rubini@...pv.it>
To:	linus.walleij@...aro.org
Cc:	nikai@...ai.net, linux@....linux.org.uk,
	linux-kernel@...r.kernel.org, STEricsson_nomadik_linux@...t.st.com,
	tglx@...utronix.de, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] arm: nomadik: avoid assigning u32 to bool

>> -       enabled = nmk_chip->enabled & bitmask;
>> +       enabled = !!(nmk_chip->enabled & bitmask);
> 
> I've learned to live this way of casting stuff into boolean,

I use (and love) !! since I learnt C. What I really dislike is the
concept of boolean that doesn't fit in the C way of thinking, in my opinion.
But I'm not going to change that.

Acked-by: Alessandro Rubini <rubini@...pv.it>

/alessandro
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/