linux-kernel - Re: linux-next: Tree for April 1 [BROKEN ubifs when CONFIG_DEBUG_SECTION

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110402112037.ca288d7b.sfr@canb.auug.org.au>
Date:	Sat, 2 Apr 2011 11:20:37 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	sedat.dilek@...il.com
Cc:	Jens Axboe <jaxboe@...ionio.com>,
	Sedat Dilek <sedat.dilek@...glemail.com>, dedekind1@...il.com,
	linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: Tree for April 1 [BROKEN ubifs when
 CONFIG_DEBUG_SECTION_MISMATCH=y]s

cc'ing Jens ...

On Fri, 1 Apr 2011 20:22:41 +0200 Sedat Dilek <sedat.dilek@...glemail.com> wrote:
>
> On Fri, Apr 1, 2011 at 7:02 PM, Artem Bityutskiy <dedekind1@...il.com> wrote:
> > On Fri, 2011-04-01 at 18:10 +0200, Sedat Dilek wrote:
> >> On Fri, Apr 1, 2011 at 6:06 PM, Stephen Rothwell <sfr@...b.auug.org.au> wrote:
> >> > Cc'ing Artem,
> >> >
> >> > On Fri, 1 Apr 2011 17:55:52 +0200 Sedat Dilek <sedat.dilek@...glemail.com> wrote:
> >> >>
> >> >> With CONFIG_DEBUG_SECTION_MISMATCH=y set, I see in my build.log:
> >> >> ...
> >> >> MODPOST 2742 modules
> >> >> ...
> >> >> ERROR: "empty_aops" [fs/ubifs/ubifs.ko] undefined!
> >> >> make[5]: *** [__modpost] Error 1
> >> >> make[4]: *** [modules] Error 2
> >> >> make[3]: *** [sub-make] Error 2
> >> >> make[2]: *** [all] Error 2
> >> >> make[2]: Leaving directory
> >> >> `/home/sd/src/linux-2.6/linux-2.6.39-rc1/debian/build/build_i386_none_686-iniza'
> >> >>
> >> >> - Sedat -
> >> >>
> >> >
> >> >
> >> > --
> >> > Cheers,
> >> > Stephen Rothwell                    sfr@...b.auug.org.au
> >> > http://www.canb.auug.org.au/~sfr/
> >> >
> >>
> >> Speculative patch (untested).
> >>
> >> - Sedat -
> >>
> >> $ diff -uprN fs/ubifs/xattr.c.orig fs/ubifs/xattr.c
> >> --- fs/ubifs/xattr.c.orig       2011-04-01 15:56:08.471082117 +0200
> >> +++ fs/ubifs/xattr.c    2011-04-01 18:08:27.355276827 +0200
> >> @@ -81,6 +81,7 @@ enum {
> >>
> >>  static const struct inode_operations none_inode_operations;
> >>  static const struct file_operations none_file_operations;
> >> +static const struct address_space_operations empty_aops;
> >>
> >>  /**
> >>   * create_xattr - create an extended attribute.
> >
> > ubifs doess not have 'empty_aops' symbol and does not use such symbol. I
> > do not understand how you got that build issue, but this must be
> > something to do with your local setup.
> >
> > Also:
> >
> > [dedekind@eru linux-next (master)]$ grep -r 'empty_aops' *
> > fs/nilfs2/page.c:       static const struct address_space_operations empty_aops;
> > fs/nilfs2/page.c:       mapping->a_ops = &empty_aops;
> > fs/inode.c:     static const struct address_space_operations empty_aops;
> > fs/inode.c:     mapping->a_ops = &empty_aops;
> >
> > in the current linux-next.
> >
> > --
> > Best Regards,
> > Artem Bityutskiy (Артём Битюцкий)
> >
> >
> 
> You are right, I pulled linux-2.6-block.git#for-linus into linux-next.
> Looks like linux-2.6-block-for-linus/0007-fs-export-empty_aops.patch
> is causing this [1].
> 
> - Sedat -
> 
> [1] http://git.kernel.org/?p=linux/kernel/git/axboe/linux-2.6-block.git;a=commit;h=2c9214b7b72cf440024d8b91523eea25bbc76040
> 


-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped