From 4cc523d660d5c9476ad5e6af9ff155551e72a2dc Mon Sep 17 00:00:00 2001 From: Sedat Dilek Date: Sat, 2 Apr 2011 12:33:44 +0200 Subject: [PATCH 3/3] ubifs: Move {inode,file}_operations to create_xattr() and use empty_{iops,fops} Consider inode_operations and file_operations have also no functions defined and move them to create_xattr(). Transform to empty_{iops,fops} (see fs/inode.c and fs/open.c). Signed-off-by: Sedat Dilek --- fs/ubifs/xattr.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/fs/ubifs/xattr.c b/fs/ubifs/xattr.c index 29d5681..d237c4f 100644 --- a/fs/ubifs/xattr.c +++ b/fs/ubifs/xattr.c @@ -79,9 +79,6 @@ enum { SECURITY_XATTR, }; -static const struct inode_operations none_inode_operations; -static const struct file_operations none_file_operations; - /** * create_xattr - create an extended attribute. * @c: UBIFS file-system description object @@ -100,6 +97,8 @@ static int create_xattr(struct ubifs_info *c, struct inode *host, const struct qstr *nm, const void *value, int size) { static const struct address_space_operations empty_aops = {}; + static const struct inode_operations empty_iops = {}; + static const struct file_operations empty_fops = {}; int err; struct inode *inode; struct ubifs_inode *ui, *host_ui = ubifs_inode(host); @@ -131,8 +130,8 @@ static int create_xattr(struct ubifs_info *c, struct inode *host, /* Re-define all operations to be "nothing" */ inode->i_mapping->a_ops = &empty_aops; - inode->i_op = &none_inode_operations; - inode->i_fop = &none_file_operations; + inode->i_op = &empty_iops; + inode->i_fop = &empty_fops; inode->i_flags |= S_SYNC | S_NOATIME | S_NOCMTIME | S_NOQUOTA; ui = ubifs_inode(inode); -- 1.7.4.3