linux-kernel - Re: [PATCH] avr32: init cannot ignore signals sent by force_sig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110404160447.GB23655@redhat.com>
Date:	Mon, 4 Apr 2011 18:04:47 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Matt Fleming <matt@...sole-pimps.org>
Cc:	Hans-Christian Egtvedt <hans-christian.egtvedt@...el.com>,
	linux-kernel@...r.kernel.org,
	Matt Fleming <matt.fleming@...ux.intel.com>
Subject: Re: [PATCH] avr32: init cannot ignore signals sent by
	force_sig_info()

On 04/04, Matt Fleming wrote:
>
> --- a/arch/avr32/kernel/traps.c
> +++ b/arch/avr32/kernel/traps.c
> @@ -95,28 +95,6 @@ void _exception(long signr, struct pt_regs *regs, int code,
>  	info.si_code = code;
>  	info.si_addr = (void __user *)addr;
>  	force_sig_info(signr, &info, current);
> -
> -	/*
> -	 * Init gets no signals that it doesn't have a handler for.
> -	 * That's all very well, but if it has caused a synchronous
> -	 * exception and we ignore the resulting signal, it will just
> -	 * generate the same exception over and over again and we get
> -	 * nowhere.  Better to kill it and let the kernel panic.
> -	 */
> -	if (is_global_init(current)) {
> -		__sighandler_t handler;
> -
> -		spin_lock_irq(&current->sighand->siglock);
> -		handler = current->sighand->action[signr-1].sa.sa_handler;
> -		spin_unlock_irq(&current->sighand->siglock);
> -		if (handler == SIG_DFL) {
> -			/* init has generated a synchronous exception
> -			   and it doesn't have a handler for the signal */
> -			printk(KERN_CRIT "init has generated signal %ld "
> -			       "but has no handler for it\n", signr);
> -			do_exit(signr);
> -		}
> -	}

Reviewed-by: Oleg Nesterov <oleg@...hat.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/