[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 4 Apr 2011 20:03:13 +0200
From: Sedat Dilek <sedat.dilek@...glemail.com>
To: Joe Perches <joe@...ches.com>
Cc: Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
Matthew Garrett <mjg@...hat.com>,
Stephen Rothwell <sfr@...b.auug.org.au>,
ibm-acpi-devel@...ts.sourceforge.net,
platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/2] thinkpad_acpi: Convert printks to pr_<level>
On Mon, Apr 4, 2011 at 7:06 PM, Joe Perches <joe@...ches.com> wrote:
> Add pr_fmt.
> Removed local TPACPI_<level> #defines, convert to pr_<level>.
> Neaten dbg_<foo> macros.
> Added a few missing newlines to logging messages.
> Added static inline str_supported for !CONFIG_THINKPAD_ACPI_DEBUG vdbg_printk
> defect reported by Sedat Dilek <sedat.dilek@...glemail.com>.
>
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 472 ++++++++++++++--------------------
> 1 files changed, 188 insertions(+), 284 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
[...]
> #ifdef CONFIG_THINKPAD_ACPI_DEBUG
> #define vdbg_printk dbg_printk
> static const char *str_supported(int is_supported);
> #else
> -#define vdbg_printk(a_dbg_level, format, arg...) \
> - do { } while (0)
> +static inline const char *str_supported(int is_supported) { return ""; }
> +#define vdbg_printk(a_dbg_level, format, arg...) \
> + no_printk(format, ##arg)
> #endif
Should be...
+ do { } while (0)
...not...
+ no_printk(format, ##arg)
- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists