linux-kernel - Re: [PATCH V2 2/2] thinkpad_acpi: Convert printks to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2011 20:14:05 +0200
From:	Sedat Dilek <sedat.dilek@...glemail.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Matthew Garrett <mjg@...hat.com>,
	Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2 2/2] thinkpad_acpi: Convert printks to pr_<level>

On Mon, Apr 4, 2011 at 8:10 PM, Joe Perches <joe@...ches.com> wrote:
> On Mon, 2011-04-04 at 20:03 +0200, Sedat Dilek wrote:
>> On Mon, Apr 4, 2011 at 7:06 PM, Joe Perches <joe@...ches.com> wrote:
>> > diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
>> [...]
>> >  #ifdef CONFIG_THINKPAD_ACPI_DEBUG
>> >  #define vdbg_printk dbg_printk
>> >  static const char *str_supported(int is_supported);
>> >  #else
>> > -#define vdbg_printk(a_dbg_level, format, arg...) \
>> > -       do { } while (0)
>> > +static inline const char *str_supported(int is_supported) { return ""; }
>> > +#define vdbg_printk(a_dbg_level, format, arg...)       \
>> > +       no_printk(format, ##arg)
>> >  #endif
>>
>> Should be...
>> +       do { } while (0)
>> ...not...
>> +       no_printk(format, ##arg)
>
> I disagree.  No printk serves as a mechanism to verify
> printk arguments when !CONFIG_THINKPAD_ACPI_DEBUG.
>

Oops sorry, now I see you have chosen solution #1 :-).

- Sedat -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/