linux-kernel - Re: [PATCH] tile,mn10300: add device parameter to dma_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2011 15:16:03 -0400
From:	Chris Metcalf <cmetcalf@...era.com>
To:	James Hogan <james@...anarts.com>
CC:	David Howells <dhowells@...hat.com>,
	Koichi Yasutake <yasutake.koichi@...panasonic.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	James Hogan <james.hogan@...tec.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Arnd Bergmann <arnd@...db.de>, <linux-am33-list@...hat.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tile,mn10300: add device parameter to dma_cache_sync()

On 4/4/2011 11:21 AM, James Hogan wrote:
> From: James Hogan <james.hogan@...tec.com>
>
> Note: I'm not in a position to compile test this patch, but I don't
> foresee any problems.
>
> Since v2.6.20 "Pass struct dev pointer to dma_cache_sync()"
> (d3fa72e4556ec1f04e46a0d561d9e785ecaa173d), dma_cache_sync() takes a
> struct dev pointer, but these appear to be missing from the tile and
> mn10300 implementations, so add them.
>
> Signed-off-by: James Hogan <james.hogan@...tec.com>
> ---
>  arch/mn10300/include/asm/dma-mapping.h |    2 +-
>  arch/tile/include/asm/dma-mapping.h    |    3 ++-
>  arch/tile/kernel/pci-dma.c             |    2 +-

This change looks fine for tile (not compile-tested but pretty obvious), so

Acked-by: Chris Metcalf <cmetcalf@...era.com>

assuming you're planning to push this up yourself.

Apparently we've never tried to build anything that uses this API
(sata_dwc_460ex.c, lasi_82596.c, 53c700.c, etc.).

-- 
Chris Metcalf, Tilera Corp.
http://www.tilera.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/