linux-kernel - Re: linux-next: Tree for April 4 [BROKEN thinkpad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1302006475.6449.1437647773@webmail.messagingengine.com>
Date:	Tue, 05 Apr 2011 09:27:55 -0300
From:	"Henrique de Moraes Holschuh" <hmh@....eng.br>
To:	"Matthew Garrett" <mjg@...hat.com>, "Joe Perches" <joe@...ches.com>
Cc:	"Stephen Rothwell" <sfr@...b.auug.org.au>, sedat.dilek@...il.com,
	linux-next@...r.kernel.org, "LKML" <linux-kernel@...r.kernel.org>,
	"platform-driver-x86" <platform-driver-x86@...r.kernel.org>
Subject: Re: linux-next: Tree for April 4 [BROKEN thinkpad_acpi]

On Mon, 04 Apr 2011 14:00 +0100, "Matthew Garrett" <mjg@...hat.com> wrote:
> On Mon, Apr 04, 2011 at 05:49:29AM -0700, Joe Perches wrote:
> 
> > It's vdbg_printk no_printk verification.
> > 
> > #ifdef CONFIG_THINKPAD_ACPI_DEBUG
> > #define vdbg_printk dbg_printk
> > static const char *str_supported(int is_supported);
> > #else
> > #define vdbg_printk(a_dbg_level, format, arg...)	\
> > 	no_printk(format, ##arg)
> > #endif
> > 
> > Two ways to handle this.
> > 
> > 1: add
> > static inline const char *str_supported(int is_supported) { return ""; }
> > to the #else
> > 
> > 2: Remove no_printk verification and return it to do {} while (0)
> > 
> > Do you have a preference?
> 
> I don't. Henrique?

No set preference, either way is fine.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/