linux-kernel - Re: [PATCH 1/5] usb: gadget: f_mass_storage: Fix Bulk-only RESET handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <op.vtg26ick3l0zgt@mnazarewicz-glaptop>
Date:	Tue, 05 Apr 2011 18:09:44 +0200
From:	"Michal Nazarewicz" <mina86@...a86.com>
To:	gregkh@...e.de, "Roger Quadros" <roger.quadros@...ia.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] usb: gadget: f_mass_storage: Fix Bulk-only RESET
 handling

On Tue, 05 Apr 2011 17:36:38 +0200, Roger Quadros  
<roger.quadros@...ia.com> wrote:
> The ep0 request tag was not recorded thus resulting in phase
> problems while sending status/response in handle_execption() handler.
> This was resulting in MSC compliance test failures with USBCV tool.
>
> With this patch, the Bulk-Only Mass storage RESET request is
> handled correctly and the MSC compliance tests pass.
>
> Signed-off-by: Roger Quadros <roger.quadros@...ia.com>

Acked-by: Michal Nazarewicz <mina86@...a86.com>

> --- a/drivers/usb/gadget/f_mass_storage.c
> +++ b/drivers/usb/gadget/f_mass_storage.c
> @@ -613,6 +613,11 @@ static int fsg_setup(struct usb_function *f,
>  	if (!fsg_is_set(fsg->common))
>  		return -EOPNOTSUPP;
> +	++fsg->common->ep0_req_tag;	/* Record arrival of a new request */
> +	req->context = NULL;
> +	req->length = 0;
> +	dump_msg(fsg, "ep0-setup", (u8 *) ctrl, sizeof(*ctrl));
> +
>  	switch (ctrl->bRequest) {
> 	case USB_BULK_RESET_REQUEST:

-- 
Best regards,                                         _     _
.o. | Liege of Serenely Enlightened Majesty of      o' \,=./ `o
..o | Computer Science,  Michal "mina86" Nazarewicz    (o o)
ooo +-----<email/xmpp: mnazarewicz@...gle.com>-----ooO--(_)--Ooo--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/