| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20110405162306.GA1800@kroah.com> Date: Tue, 5 Apr 2011 09:23:06 -0700 From: Greg KH <greg@...ah.com> To: Haiyang Zhang <haiyangz@...rosoft.com> Cc: hjanssen@...rosoft.com, kys@...rosoft.com, v-abkane@...rosoft.com, gregkh@...e.de, linux-kernel@...r.kernel.org, devel@...uxdriverproject.org, virtualization@...ts.osdl.org, stable <stable@...nel.org>, Mike Surcouf <mike@...couf.co.uk> Subject: Re: [PATCH] staging: hv: Fix GARP not sent after Quick Migration On Tue, Apr 05, 2011 at 09:24:15AM -0700, Haiyang Zhang wrote: > After Quick Migration, the network is not immediately operational in the > current context when receiving RNDIS_STATUS_MEDIA_CONNECT event. So, I put > the netif_notify_peers() into a scheduled work, otherwise GARP packet will > not be sent after quick migration, and cause network disconnection. Wait, what are you relying on here for the delay? What happens when processors get faster and that work queue gets run even sooner than today? You are relying on the scheduler to introduce a "delay" here and you can't rely on that at all. Instead, use a proper timer as you do know how long you need to wait, right? Don't abuse workqueues for something they were not designed for. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists