linux-kernel - Re: [PATCH 01/34] kconfig: Do not record timestamp in auto.conf and autoconf.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTinwKzasKmB_fFzXd+W7F6GGuPO6+g@mail.gmail.com>
Date:	Tue, 5 Apr 2011 14:57:44 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/34] kconfig: Do not record timestamp in auto.conf and autoconf.h

Hi,

On Tue, Apr 5, 2011 at 10:58 AM, Michal Marek <mmarek@...e.cz> wrote:
> Timestamps in file data are useless and there is already one in .config
>
hum, shouldn't this be tunable via KCONFIG_NOTIMESTAMP ? This might be
useful to know when the file was generated, independently of the
.config, as conf_write() and conf_write_autoconf() are independent
from one another.

 - Arnaud

> Signed-off-by: Michal Marek <mmarek@...e.cz>
> ---
>  scripts/kconfig/confdata.c |    8 ++------
>  1 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/scripts/kconfig/confdata.c b/scripts/kconfig/confdata.c
> index 61c35bf..834eecb 100644
> --- a/scripts/kconfig/confdata.c
> +++ b/scripts/kconfig/confdata.c
> @@ -784,7 +784,6 @@ int conf_write_autoconf(void)
>        const char *str;
>        const char *name;
>        FILE *out, *tristate, *out_h;
> -       time_t now;
>        int i;
>
>        sym_clear_all_valid();
> @@ -811,22 +810,19 @@ int conf_write_autoconf(void)
>                return 1;
>        }
>
> -       time(&now);
>        fprintf(out, "#\n"
>                     "# Automatically generated make config: don't edit\n"
>                     "# %s\n"
> -                    "# %s"
>                     "#\n",
> -                    rootmenu.prompt->text, ctime(&now));
> +                    rootmenu.prompt->text);
>        fprintf(tristate, "#\n"
>                          "# Automatically generated - do not edit\n"
>                          "\n");
>        fprintf(out_h, "/*\n"
>                       " * Automatically generated C config: don't edit\n"
>                       " * %s\n"
> -                      " * %s"
>                       " */\n",
> -                      rootmenu.prompt->text, ctime(&now));
> +                      rootmenu.prompt->text);
>
>        for_all_symbols(i, sym) {
>                sym_calc_value(sym);
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/