linux-kernel - Re: [PATCH 1/2] staging: IIO driver for Analog Devices Digital Output Gyroscope ADXRS450

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110405192130.GA10106@kroah.com>
Date:	Tue, 5 Apr 2011 12:21:30 -0700
From:	Greg KH <greg@...ah.com>
To:	cliff.cai@...log.com
Cc:	gregkh@...e.de, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, jic23@....ac.uk,
	device-drivers-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 1/2] staging: IIO driver for Analog Devices Digital
 Output Gyroscope ADXRS450

On Fri, Mar 25, 2011 at 12:05:57PM +0800, cliff.cai@...log.com wrote:
> From: Cliff Cai <cliff.cai@...log.com>
> 
> Add new IIO driver for Analog Devices digital output gyroscope ADXRS450
> 
> Signed-off-by: Cliff Cai <cliff.cai@...log.com>
> Acked-by: Jonathan Cameron <jic23@....ac.uk>

This breaks the build:
  CC [M]  drivers/staging/iio/gyro/adxrs450_core.o
drivers/staging/iio/gyro/adxrs450_core.c:329:70: error: expected ‘)’ before numeric constant
drivers/staging/iio/gyro/adxrs450_core.c:337:3: error: ‘iio_dev_attr_gyro_z_quadrature_correction_raw’ undeclared here (not in a function)
drivers/staging/iio/gyro/adxrs450_core.c:216:16: warning: ‘adxrs450_read_quad’ defined but not used

Please test your patches before you send them out, it wastes everyone's
time when you don't :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/