linux-kernel - [RFC-v3 0/3] qla2xxx LLD target mode + tcm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:	Mon,  4 Apr 2011 22:11:44 -0700
From:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
To:	linux-scsi <linux-scsi@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	Christoph Hellwig <hch@....de>, Hannes Reinecke <hare@...e.de>,
	Mike Christie <michaelc@...wisc.edu>
Cc:	Madhu Iyengar <madhu.iyengar@...gic.com>,
	Andrew Vasquez <andrew.vasquez@...gic.com>,
	Ruediger Oertel <ro@...e.de>, Andy Grover <agrover@...hat.com>,
	Nicholas Bellinger <nab@...ux-iscsi.org>
Subject: [RFC-v3 0/3] qla2xxx LLD target mode + tcm_qla2xxx fabric module

From: Nicholas Bellinger <nab@...ux-iscsi.org>

Greetings James, Christoph, Hannes, and Co,

Attached is the third RFC series for adding qla2xxx LLD target mode support
into mainline v8.03.07.00 @ .39-rc1, along with the accompanying tcm_qla2xxx.ko
fabric module cut against mainline target v4.0 infrastructure.  This series has
been broken up into reviewable sections and should be considered a 'for-40' item.

Many thanks to Andrew Vasquez for his initial off-list review of RFC-v2.
This updated series contains a number of cleanups + removal of unnecessary
code recommended by Andrew for enabling target mode support, and other
misc code maintainibility improvements.

So at this point with the functioning code, we would like to come to a
consensus with linux-scsi folks about how the explict qla2xxx target mode LLD
and tcm_qla2xxx fabric module 'split' should look, and how it will be accepted
into distros and maintained for mainline moving forward.  The Qlogic folks
(Madhu and Andrew) have expressed interest that they would like to eventually
own maintainence for the target pieces inside of qla2xxx, but this currently
ends up being decent chunk of code in qla_target.c that may otherwise better
reside in tcm_qla2xxx code.

So that said, I would really like to get opinions from Christoph, Hannes,
and Mike about how the 'existing LLD / tcm_fabric.ko split' can best done
for mainline, and some input from kernel distro folks would also be useful
here.  Comments here please upstream linux-scsi folks..?

An overview of the current status, todo list, mini-howto and running layout
from /sys/kernel/config/target/qla2xxx/ are available here:

http://www.linux-iscsi.org/index.php/Qlogic
http://www.linux-iscsi.org/wiki/QLogic/configFS

The next major item will be proper target mode NPIV support for >= 24xx series
adapters using the included qla2xxx_npiv fabric skeleton, and which will be
enabled in the next round of review in RFC-v4.

Thanks!

--nab

Nicholas Bellinger (3):
  qla2xxx: Add target mode support into 2xxx series LLD code
  qla2xxx: Enable 2xxx series LLD target mode support
  tcm_qla2xxx: Add HW target mode I/O, control and TMR path code

 drivers/scsi/qla2xxx/Makefile                     |    4 +-
 drivers/scsi/qla2xxx/qla_attr.c                   |    5 +-
 drivers/scsi/qla2xxx/qla_dbg.h                    |   34 +
 drivers/scsi/qla2xxx/qla_def.h                    |   63 +-
 drivers/scsi/qla2xxx/qla_gbl.h                    |    7 +
 drivers/scsi/qla2xxx/qla_gs.c                     |    4 +-
 drivers/scsi/qla2xxx/qla_init.c                   |   79 +-
 drivers/scsi/qla2xxx/qla_iocb.c                   |  105 +-
 drivers/scsi/qla2xxx/qla_isr.c                    |   83 +-
 drivers/scsi/qla2xxx/qla_mbx.c                    |  122 +-
 drivers/scsi/qla2xxx/qla_mid.c                    |   21 +-
 drivers/scsi/qla2xxx/qla_os.c                     |  107 +-
 drivers/scsi/qla2xxx/qla_target.c                 | 5556 +++++++++++++++++++++
 drivers/scsi/qla2xxx/qla_target.h                 | 1137 +++++
 drivers/target/Kconfig                            |    1 +
 drivers/target/Makefile                           |    1 +
 drivers/target/tcm_qla2xxx/Kconfig                |    7 +
 drivers/target/tcm_qla2xxx/Makefile               |    6 +
 drivers/target/tcm_qla2xxx/tcm_qla2xxx_base.h     |  102 +
 drivers/target/tcm_qla2xxx/tcm_qla2xxx_configfs.c | 1439 ++++++
 drivers/target/tcm_qla2xxx/tcm_qla2xxx_fabric.c   |  853 ++++
 drivers/target/tcm_qla2xxx/tcm_qla2xxx_fabric.h   |   53 +
 22 files changed, 9750 insertions(+), 39 deletions(-)
 create mode 100644 drivers/scsi/qla2xxx/qla_target.c
 create mode 100644 drivers/scsi/qla2xxx/qla_target.h
 create mode 100644 drivers/target/tcm_qla2xxx/Kconfig
 create mode 100644 drivers/target/tcm_qla2xxx/Makefile
 create mode 100644 drivers/target/tcm_qla2xxx/tcm_qla2xxx_base.h
 create mode 100644 drivers/target/tcm_qla2xxx/tcm_qla2xxx_configfs.c
 create mode 100644 drivers/target/tcm_qla2xxx/tcm_qla2xxx_fabric.c
 create mode 100644 drivers/target/tcm_qla2xxx/tcm_qla2xxx_fabric.h

-- 
1.7.4.3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/