linux-kernel - Re: [PATCH 03/12] Staging: hv: Cleanup irq management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 4 Apr 2011 21:19:50 -0700
From:	Greg KH <greg@...ah.com>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, virtualization@...ts.osdl.org,
	Haiyang Zhang <haiyangz@...rosoft.com>,
	Mike Sterling <mike.sterling@...rosoft.com>,
	Abhishek Kane <v-abkane@...rosoft.com>
Subject: Re: [PATCH 03/12] Staging: hv: Cleanup irq management

On Tue, Mar 15, 2011 at 03:03:34PM -0700, K. Y. Srinivasan wrote:
> Now that vmbus_driver is a  pci driver,
> cleanup the irq allocation mess by using the standard
> irq allocation mechanisms.
> 
> Note that this patch generates an error when the checkpatch
> script is run because of the IRQF_SAMPLE_RANDOM flag used in
> request_irq() function. This interrupt may be the only
> external event this VM will get and consequently if this
> flag (IRQF_SAMPLE_RANDOM) is not  specified, experimentally
> we have shown that the entropy in the VM will very very low.
> 
> 
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@...rosoft.com>
> Signed-off-by: Mike Sterling <mike.sterling@...rosoft.com>
> Signed-off-by: Abhishek Kane <v-abkane@...rosoft.com>
> Signed-off-by: Hank Janssen <hjanssen@...rosoft.com>
> ---
>  drivers/staging/hv/vmbus_drv.c |   28 +++++++++++++---------------
>  1 files changed, 13 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/staging/hv/vmbus_drv.c b/drivers/staging/hv/vmbus_drv.c
> index 3d2789b..239b91c 100644
> --- a/drivers/staging/hv/vmbus_drv.c
> +++ b/drivers/staging/hv/vmbus_drv.c
> @@ -17,6 +17,8 @@
>   * Authors:
>   *   Haiyang Zhang <haiyangz@...rosoft.com>
>   *   Hank Janssen  <hjanssen@...rosoft.com>
> + *
> + * 3/9/2011: K. Y. Srinivasan	- Significant restructuring and cleanup

Changelog comments never belong in the file itself.  If you consider
yourself an author of the file now, then put your name in it with the
others.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/