linux-kernel - Re: [RFC PATCH 3/7] basic_mmio_gpio: allow overriding number of gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110406121809.GA8385@oksana.dev.rtsoft.ru>
Date:	Wed, 6 Apr 2011 16:18:09 +0400
From:	Anton Vorontsov <cbouatmailru@...il.com>
To:	Jamie Iles <jamie@...ieiles.com>
Cc:	linux-kernel@...r.kernel.org, linux@....linux.org.uk,
	tglx@...utronix.de, grant.likely@...retlab.ca, arnd@...db.de,
	nico@...xnic.net
Subject: Re: [RFC PATCH 3/7] basic_mmio_gpio: allow overriding number of
 gpio

On Wed, Apr 06, 2011 at 12:10:59PM +0100, Jamie Iles wrote:
[...]
> +	if (pdata) {
> +		bgc->gc.base = pdata->base;
> +		if (pdata->ngpio > 0)
> +			ngpio = pdata->ngpio;
> +	} else
> +		bgc->gc.base = -1;

Just a minor comstic nit: 'else' case should be with braces as well.
I.e. '} else {'.

But techincally, the patch looks perfect,

Acked-by: Anton Vorontsov <cbouatmailru@...il.com>

Thanks,

-- 
Anton Vorontsov
Email: cbouatmailru@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/