linux-kernel - Re: [PATCH 4/4] Staging: iio: accel : sca3000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BANLkTin=N2gOcvbgngwZcLEGVK2qoyeLLw@mail.gmail.com>
Date:	Wed, 6 Apr 2011 21:24:50 +0200
From:	Belisko Marek <marek.belisko@...il.com>
To:	nijs.michael@...il.com
Cc:	gregkh@...e.de, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] Staging: iio: accel : sca3000_ring: Fixing code
 styling issues

On Wed, Apr 6, 2011 at 9:14 PM,  <nijs.michael@...il.com> wrote:
> From: Michael Nijs <nijs.michael@...il.com>
>
> Fixed code styling issue.
>
> Signed-off-by: Michael Nijs <nijs.michael@...il.com>
> ---
>  drivers/staging/iio/accel/sca3000_ring.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/sca3000_ring.c b/drivers/staging/iio/accel/sca3000_ring.c
> index fd1c844..c872fdd 100644
> --- a/drivers/staging/iio/accel/sca3000_ring.c
> +++ b/drivers/staging/iio/accel/sca3000_ring.c
> @@ -91,7 +91,7 @@ static int sca3000_rip_hw_rb(struct iio_ring_buffer *r,
>
>        /* Convert byte order and shift to default resolution */
>        if (st->bpse == 11) {
> -               samples = (s16 *)(*data+1);
> +               samples = (s16*)(*data+1);
Strange. My output(latest 2.6.39-rc2):
./scripts/checkpatch.pl -f drivers/staging/iio/accel/sca3000_ring.c
ERROR: "(foo*)" should be "(foo *)"
#94: FILE: staging/iio/accel/sca3000_ring.c:94:
+		samples = (s16*)(*data+1);

So for me it seems it was correct and you post patch with change where
checkpatch will bark. Or am I missing something?
>                for (i = 0; i < (num_read/2); i++) {
>                        samples[i] = be16_to_cpup(
>                                        (__be16 *)&(samples[i]));
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

thanks,

marek

-- 
as simple and primitive as possible
-------------------------------------------------
Marek Belisko - OPEN-NANDRA
Freelance Developer

Ruska Nova Ves 219 | Presov, 08005 Slovak Republic
Tel: +421 915 052 184
skype: marekwhite
icq: 290551086
web: http://open-nandra.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/