linux-kernel - Re: [patch 13/15] sched: expire slack quota using generation counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1302077732.2225.1373.camel@twins>
Date:	Wed, 06 Apr 2011 10:15:32 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Paul Turner <pjt@...gle.com>
Cc:	linux-kernel@...r.kernel.org,
	Bharata B Rao <bharata@...ux.vnet.ibm.com>,
	Dhaval Giani <dhaval.giani@...il.com>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>,
	Srivatsa Vaddagiri <vatsa@...ibm.com>,
	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>,
	Ingo Molnar <mingo@...e.hu>, Pavel Emelyanov <xemul@...nvz.org>
Subject: Re: [patch 13/15] sched: expire slack quota using generation
 counters

On Wed, 2011-04-06 at 00:22 -0700, Paul Turner wrote:
> > Argh, this patch is terrible for the reason that it changes the whole
> > accounting just introduced and me having to re-open all the previous
> > patches to look up hth stuff worked before.
> 
> I didn't think it was too drastic -- the introduction of the
> generation is more incremental.  However I agree it does cause
> unnecessary churn within the accounting functions across the series.
> Given that expiring quota is a requirement, this can be streamlined by
> introducing some of these notions earlier in the series as opposed to
> bootstrapping them at the end here -- will clean it up. 

Thanks, and yes, I imagine that when working with the patches for a few
days at end its all not really much of a problem, but for me its the
first look in many weeks and this is the 13th patch in and my brain is
about to turn to mush ;-)

I'll try and read the massive comment on the memory barrier bits once
I've managed to properly wake up..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/