linux-kernel - Re: [PATCH] cpuidle: Fix build on ARM and SH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Apr 2011 22:57:19 -0700
From:	Stephen Boyd <sboyd@...eaurora.org>
To:	Len Brown <len.brown@...el.com>
CC:	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Kevin Hilman <khilman@...prootsystems.com>,
	Paul Mundt <lethal@...ux-sh.org>, linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] cpuidle: Fix build on ARM and SH

On 4/3/2011 10:23 PM, Mark Brown wrote:
> Commit 5f8cf82 (cpuidle: stop using pm_idle) converted arches to use
> cpuidle_idle_call() but contained typos on ARM and SH transposing the
> function name into cpuidle_call_idle().
>
> Signed-off-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

When will this patch get into linux-next? Every ARM and SH build has
failed for the past 3 days presumably due to this. Stephen, can you pick
it up for the time being?

> ---
>  arch/arm/kernel/process.c |    2 +-
>  arch/sh/kernel/idle.c     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
> index dc9d685..f47660e 100644
> --- a/arch/arm/kernel/process.c
> +++ b/arch/arm/kernel/process.c
> @@ -197,7 +197,7 @@ void cpu_idle(void)
>  				cpu_relax();
>  			} else {
>  				stop_critical_timings();
> -				if (cpuidle_call_idle())
> +				if (cpuidle_idle_call())
>  					pm_idle();
>  				start_critical_timings();
>  				/*
> diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c
> index 9c7099e..1db1968 100644
> --- a/arch/sh/kernel/idle.c
> +++ b/arch/sh/kernel/idle.c
> @@ -101,7 +101,7 @@ void cpu_idle(void)
>  			local_irq_disable();
>  			/* Don't trace irqs off for idle */
>  			stop_critical_timings();
> -			if (cpuidle_call_idle())
> +			if (cpuidle_idle_call())
>  				pm_idle();
>  			/*
>  			 * Sanity check to ensure that pm_idle() returns
-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/