linux-kernel - [tip:timers/urgent] x86/mrst/vrtc: Fix boot crash in mrst_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-09552b2696896dbb715be0caf91b23276f9139ba@git.kernel.org>
Date:	Thu, 7 Apr 2011 09:49:22 GMT
From:	tip-bot for Feng Tang <feng.tang@...el.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com, hpa@...or.com,
	mingo@...hat.com, torvalds@...ux-foundation.org,
	tglx@...utronix.de, feng.tang@...el.com, mingo@...e.hu
Subject: [tip:timers/urgent] x86/mrst/vrtc: Fix boot crash in mrst_rtc_init()

Commit-ID:  09552b2696896dbb715be0caf91b23276f9139ba
Gitweb:     http://git.kernel.org/tip/09552b2696896dbb715be0caf91b23276f9139ba
Author:     Feng Tang <feng.tang@...el.com>
AuthorDate: Thu, 7 Apr 2011 09:39:49 +0800
Committer:  Ingo Molnar <mingo@...e.hu>
CommitDate: Thu, 7 Apr 2011 11:27:42 +0200

x86/mrst/vrtc: Fix boot crash in mrst_rtc_init()

The sfi_mrtc_array[] only gets initialized when the sfi mrtc
table is parsed, so the vrtc_paddr should be initalized after it
too.

Signed-off-by: Feng Tang <feng.tang@...el.com>
Signed-off-by: Alan Cox <alan@...ux.intel.com>
Cc: Linus Torvalds <torvalds@...ux-foundation.org>
Link: http://lkml.kernel.org/r/1302140389-27603-1-git-send-email-feng.tang@intel.com
Signed-off-by: Ingo Molnar <mingo@...e.hu>
---
 arch/x86/platform/mrst/vrtc.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/x86/platform/mrst/vrtc.c b/arch/x86/platform/mrst/vrtc.c
index 04cf645..73d70d6 100644
--- a/arch/x86/platform/mrst/vrtc.c
+++ b/arch/x86/platform/mrst/vrtc.c
@@ -100,9 +100,11 @@ int vrtc_set_mmss(unsigned long nowtime)
 
 void __init mrst_rtc_init(void)
 {
-	unsigned long vrtc_paddr = sfi_mrtc_array[0].phys_addr;
+	unsigned long vrtc_paddr;
 
 	sfi_table_parse(SFI_SIG_MRTC, NULL, NULL, sfi_parse_mrtc);
+
+	vrtc_paddr = sfi_mrtc_array[0].phys_addr;
 	if (!sfi_mrtc_num || !vrtc_paddr)
 		return;
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/