| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 07 Apr 2011 15:34:20 +0200 From: Mike Galbraith <efault@....de> To: Shaohua Li <shaohua.li@...el.com> Cc: linux-kernel@...r.kernel.org, mingo@...e.hu, zheng.z.yan@...el.com Subject: Re: [PATCH]sched: convert wall-time to vruntime for check_preempt_tick On Thu, 2011-04-07 at 20:43 +0800, Shaohua Li wrote: > In check_preempt_tick(), delta is vruntime and ideal_runtime is wall runtime. > Comparing vruntime and ideal_runtime looks buggy. Why is that buggy? It's a distance in units ns, ala wakeup_granularity, a number. This number just happens to be variable. > Signed-off-by: Shaohua Li <shaohua.li@...el.com> > > diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c > index 3f7ec9e..0b76e3a 100644 > --- a/kernel/sched_fair.c > +++ b/kernel/sched_fair.c > @@ -1121,7 +1121,7 @@ check_preempt_tick(struct cfs_rq *cfs_rq, struct sched_entity *curr) > if (delta < 0) > return; > > - if (delta > ideal_runtime) > + if (delta > calc_delta_fair(ideal_runtime, curr)) > resched_task(rq_of(cfs_rq)->curr); > } > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists