linux-kernel - Re: tip: New "Link:" tag to replace "LKML-Reference:"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Apr 2011 08:03:57 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
CC:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: tip: New "Link:" tag to replace "LKML-Reference:"

On 04/07/2011 07:54 AM, Peter Zijlstra wrote:
> 
> Can't we use a prepare-commit-msg or commit-msg hook to re-write the
> commit message to include a Link tag when one is missing, using
> something like:
> 
> Link: http://lkml.kernel.org/r/tip-$SHA@git.kernel.org
> 
> And have the post-commit hook that sends the messages recognize this
> form and send the message using the correct msgid.
> 
> That way the commit includes a correct and clickable link, doesn't
> require magic knowledge and doesn't need the committer to do extra work.
> 

To summarize the problem I hinted at earlier:

1. The link that ends up in the commit message needs to be unique, or
   it is not going to be a working future-clickable link.
2. The link that ends up in the commit message CANNOT use the SHA1 of
   the commit itself, since the commit SHA1 is derived from the entire
   commit object including the message;
3. As a result, the only option is for the robot to change the
   Message-ID to something other than the SHA1 of the commit.  It is a
   bit unfortunate, but probably not disastrous.

	-hpa

-- 
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel.  I don't speak on their behalf.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/