linux-kernel - Re: [GIT PULL] Fix common misspellings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Apr 2011 16:16:31 -0300
From:	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	trivial@...nel.org, lucas.de.marchi@...il.com
Subject: Re: [GIT PULL] Fix common misspellings

On Thu, Apr 7, 2011 at 3:28 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
> Ok, I pulled it, but some checking shows that not all of the
> corrections are correct.
>
> For example:
>
>  @@ -557 +557 @@ struct sctp_ulpevent *sctp_ulpevent_make_send_failed(
>         * ressemble/resemble a fragmented message.
>
> (this is with "word diff"), the "ressemble" was corrected to
> "resemble". But the correct spelling in this case is actually
> "reassemble".

Ok, I'll disable the automatic fix for this one in codespell, so it
doesn't hides itself  with other fixes.


>
> Another example:
>
>  @@ -317 +317 @@ static struct clk timer2_clk = {
>          .usecount = 1,              /* REVISIT: why cant'can't' this
> be disabled? */
>
> where (cant') was changed into (can't') - notice the extra apostrophe
> (it used to be there, just transposed with the 't' - there were at
> least three of those).

Right.. the problem here is that  ' was considered a word boundary.

>
> Regardless, those were the only ones I _noticed_, there may well be
> others. I'd suggest people try to find more. The easiest way I found
> to go through it was:
>
>   git show -U0 --color-words 25985edcedea

This is awesome! Much easier than the --word-diff I was using. Thanks.

Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/