linux-kernel - Re: [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in lme_firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1104072158590.1538@swampdragon.chaosbits.net>
Date:	Thu, 7 Apr 2011 21:59:27 +0200 (CEST)
From:	Jesper Juhl <jj@...osbits.net>
To:	Malcolm Priestley <tvboxspy@...il.com>
cc:	Mauro Carvalho Chehab <mchehab@...radead.org>,
	David Härdeman <david@...deman.nu>,
	Jarod Wilson <jarod@...hat.com>, linux-kernel@...r.kernel.org,
	linux-media@...r.kernel.org
Subject: Re: [PATCH][media] DVB, USB, lmedm04: Fix firmware mem leak in
 lme_firmware_switch()

On Thu, 7 Apr 2011, Malcolm Priestley wrote:

> On Thu, 2011-04-07 at 21:46 +0200, Jesper Juhl wrote:
> > Don't leak 'fw' in 
> > drivers/media/dvb/dvb-usb/lmedm04.c::lme_firmware_switch() by failing to 
> > call release_firmware().
> > 
> > Signed-off-by: Jesper Juhl <jj@...osbits.net>
> > ---
> >  lmedm04.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> >  compile tested only
> > 
> > diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c
> > index cd26e7c..d7cc625 100644
> > --- a/drivers/media/dvb/dvb-usb/lmedm04.c
> > +++ b/drivers/media/dvb/dvb-usb/lmedm04.c
> > @@ -799,7 +799,7 @@ static int lme_firmware_switch(struct usb_device *udev, int cold)
> >  	if (cold) {
> >  		info("FRM Changing to %s firmware", fw_lme);
> >  		lme_coldreset(udev);
> > -		return -ENODEV;
> > +		ret = -ENODEV;
> >  	}
> >  
> >  	release_firmware(fw);
> 
> This has already been fixed in this commit
> 
> http://git.linuxtv.org/media_tree.git?a=commit;h=b328817a2a391d1e879c4252cd3f11a352d3f3bc
> 
I see. Thanks. I was not aware of that.

-- 
Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/