linux-kernel - Re: [PATCH 1/2] rename alloc_pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1302213537.8184.4105.camel@nimitz>
Date:	Thu, 07 Apr 2011 14:58:57 -0700
From:	Dave Hansen <dave@...ux.vnet.ibm.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Timur Tabi <timur@...escale.com>,
	Andi Kleen <andi@...stfloor.org>, Mel Gorman <mel@....ul.ie>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH 1/2] rename alloc_pages_exact()

On Thu, 2011-04-07 at 14:40 -0700, David Rientjes wrote:
> > alloc_pages_exact() returns a virtual address.  But, alloc_pages() returns
> > a 'struct page *'.  That makes for very confused kernel hackers.
> > 
> > __get_free_pages(), on the other hand, returns virtual addresses.  That
> > makes alloc_pages_exact() a much closer match to __get_free_pages(), so
> > rename it to get_free_pages_exact().
> > 
> 
> The patch also reverses the arguments of the function in 
> include/linux/gfp.h, undoubtedly to resemble the (mask, order) appearance 
> of __get_free_pages():
> 
> 	-void *alloc_pages_exact(size_t size, gfp_t gfp_mask);
> 	+void *get_free_pages_exact(gfp_t gfp_mask, size_t size);

Thanks.  I dumped the fixes for that in the second patch.  Whoops.  Will
repost.

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/